Update test_shape.py #1477
Closed
Update test_shape.py #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing a non-sensical test
|
Why is it nonsensical? Seems correct? User requested to squeeze a dim that can't be squeezed, but we only know that at runtime what the length of that dimension is |
ricardoV94
force-pushed
the
labeled_tensors
branch
12 times, most recently
from
2952b1a to
71bc4ef
Compare
ricardoV94
force-pushed
the
labeled_tensors
branch
from
71bc4ef to
41d9be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ricardoV94 Let's remove this nonsensical test
📚 Documentation preview 📚: https://pytensor--1477.org.readthedocs.build/en/1477/